Improvement/mftf 33583 eliminate aspect mock from mock module resolver builder #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generator-test' of github.com:anzin/magento2-functional-testing-framework into improvement/mftf-33583-eliminate-aspect-mock-from-mock-module-resolver-builder
…ject-handler-test' of github.com:bohdan-harniuk/magento2-functional-testing-framework into improvement/mftf-33583-eliminate-aspect-mock-from-mock-module-resolver-builder
magento-engcom-team
added
Partner: Atwix
partners-contribution
|
Hello, @jilu1! This PR should be merged after all related PRs. For now, few unit tests are failed because this PR requires all those PRs to be in the develop branch. After develop branch includes them, I will merge develop branch into this branch. Thanks, Bohdan |
andrewbess
previously approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Hello @bohdan-harniuk
Thank you for your contribution.
Great job.
5 tasks
jilu1
reviewed
Aug 11, 2021
There was a problem hiding this comment.
@bohdan-harniuk Please bring the branch up to date and resolve conflicts.
…ing-framework into improvement/mftf-33583-eliminate-aspect-mock-from-mock-module-resolver-builder
|
Hello, @jilu1! I've actualised this branch. Thank you! |
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
andrewbess
approved these changes
Aug 11, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminated AspectMock usage for the MockModuleResolverBuilder.
Fixed Issues (if relevant)
Into this branch was merged the next PRs (this PR relates to them and has code changes in the files changed in that PRs):
Related Pull Requests
#852
#857
#843
#837
#848
#846
#845
#859
#856
#855
#842
#839
#853
#840
#844
#850
Contribution checklist